Reviews and quality

Reviewing draft pull requests

What comes back for each story, and what to check before you merge.

Every story comes back as a draft pull request in your repository. A person in your team reviews it and decides; Yavaren never merges.

What the pull request contains

• The change, on a new branch named after the story.
• A description: what was changed and why, how it was checked, and anything the engineer was unsure about.
• The results of the checks Yavaren ran (build, tests, linters) where your repository has them.

What to check

1. The change does what the story asks, and nothing else.
2. The tests describe the behaviour, not the implementation.
3. Files your team protects were not touched (Yavaren removes changes to protected paths before it pushes).
4. The checks in your own pipeline pass.

If the change is not right, comment on the pull request or the story and hand it over again; the engineer revises it on the same branch, up to the number of revisions the project allows.

Stopping work

An admin can stop a story that is waiting or running: open it under Recent work › Details and choose Stop this job. The engineer stops; nothing is pushed after it stops; the draft pull request, if any, stays. Stopped work is never started again by itself: hand the item over again when you want it done. Work that has already finished cannot be stopped. Show older work under the list reads further back than the latest 25.

Telling us how it went

Use Feedback on a finished piece of work to rate it and say what could be better. Your feedback is used to improve how engineers work.